Gallery #28
No reviewers
Labels
No labels
Confirmed
Confirmed
Confirmed
Duplicate
Confirmed
Invalid
Confirmed
Review Needed
Confirmed
Won't Fix
Digital Dash
JavaScript
React
JavaScript
Svelte
Kind
Bug
Kind
Enhancement
Kind
Feature
Kind
Security
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Role
All Members
Role
Future Software Lead
Role
Intermediate Member
Role
Junior Member
Role
Senior Member
Role
Software Lead
Size
L
Size
M
Size
S
Size
XL
Size
XS
Status
Abandoned
Status
Blocked
Status
Help wanted
Status
Need More Info
Status
Question
Tech
Actions
Tech
C
Tech
C++
Tech
CSS
Tech
Docker
Tech
Draw.io
Tech
Golang
Tech
HTML
Tech
JavaScript
Tech
Python
Tech
Rust
Tech
Terraform
UI
Component
UI
Layout
UI
Page
Work Type
Design Work
Work Type
Development
Work Type
Documentation
Work Type
Review
Work Type
Testing
No milestone
No project
No assignees
2 participants
Notifications
Due date
Depends on
#1 Gallery Component - Programming
ucalgary-baja/ucalg-baja-ca
#20 Gallery Component Mobile - Programming
ucalgary-baja/ucalg-baja-ca
Reference
ucalgary-baja/ucalg-baja-ca!28
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "Gallery"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Merging Gallery component into the dev branch
@Aarsh-T Just make these changes, remove unused and ensure it passes the upload test
@ -0,0 +8,4 @@'https://pictures.altai-travel.com/1920x1040/mount-everest-aerial-view-himalayas-istock-3745.jpg']} = $props();change to new list of dictionaries
@ -0,0 +20,4 @@function prevSet() {current_index = (current_index - 1 + photos.length) % photos.length;}generalize these two functions
take in a number and replace + - 1 with + input
and use {()=> functionName(+/-1)}
@ -0,0 +38,4 @@}, 5000);</script><div class="gallery-container">classes are not needed use
@ -0,0 +44,4 @@src={photos[(current_index - 1 + photos.length) % photos.length]}alt=""class="main-photo"on:click={() => openDialog(photos[(current_index - 1 + photos.length) % photos.length])}surround with a tag for accessibility and move the onlick to the
same with the other 3 img
@ -0,0 +58,4 @@class="main-photo"on:click={() => openDialog(photos[(current_index + 1) % photos.length])}/></div>also not needed
use
@ -0,0 +68,4 @@{#if dialogOpen}<dialog open class="image-dialog" onclick={closeDialog}><div class="dialog-content">class is not needed here
nor for above
@ -0,0 +70,4 @@{#if dialogOpen}<dialog open class="image-dialog" on:click={closeDialog}><div class="dialog-content" on:click|stopPropagation>class is not needed, use
@ -0,0 +118,4 @@}.button-container button.selected {background-color: rgba(255, 255, 255, 0.7);only selected is needed
using just selected removes the highlight feature for the button for some reason, so i changed it to simply div div:nth-child(2) .selected
@ -0,0 +142,4 @@position: fixed;max-width: 90%;max-height: 90%;}don't need dialog in front
@ -132,4 +135,1 @@max-width: 700px;padding: 0 1svw;}this shouldn't have been removed
@ -121,4 +128,0 @@height: 400px;width: 400px;}also put back if no warning for unused
replace with .jpg instead of .JPG to fix check
Make these changes
@ -0,0 +32,4 @@current_index = (current_index + step + photos.length) % photos.length;}function openDialog(image) {comment your functions
here is how for Javacript
@ -0,0 +42,4 @@dialogOpen = false;selected = 0;startTimer();}merge open and close dialog into one use
and a if statement with the clearTimeout or start timer
@ -0,0 +197,4 @@padding: 0;}div div:nth-child(2) .selected {why is there a selector before a class
@ -0,0 +169,4 @@}div:first-of-type > div:first-child > img:nth-child(1),div:first-of-type > div:first-child > img:nth-child(3) {use the odd selector
just change from event to null
@ -0,0 +94,4 @@}/*** @param {event} - takes the event at which the finger mves across the screenparam null
@ -0,0 +95,4 @@}/*** @param {null} event - takes the event at which the finger mves across the screenuse event type instead
Good, only one minor styling problem, this should be fixed on dev then getting another reivew
@ -0,0 +269,4 @@max-height: 90%;}dialog #window-image {dont need the dialog before but it looks more readible