Gallery #28

Merged
cnidariaware merged 14 commits from Gallery into dev 2025-11-26 20:36:02 -07:00
Member

Merging Gallery component into the dev branch

Merging Gallery component into the dev branch
Aarsh-T self-assigned this 2025-11-19 19:30:14 -07:00
(feat): Added Contact Us page, improved CSS.
Some checks are pending
Deploy to Cloudflare Pages / deploy (push) Waiting to run
9aa052cf8e
feat(About): Added numbers section.
Some checks are pending
Deploy to Cloudflare Pages / deploy (push) Waiting to run
9177f58a5b
feat(Contact CSS): Improved and descriptive
Some checks are pending
Deploy to Cloudflare Pages / deploy (push) Waiting to run
3784895549
bug(main page): fixed sponsor hyperlinks
Some checks are pending
Deploy to Cloudflare Pages / deploy (push) Waiting to run
6c944ff08f
Merge branch 'dev' of ssh://ssh.forge.ucalgarybaja.ca:222/UCalgary_Baja/ucalg-baja-ca into dev
Some checks are pending
Deploy to Cloudflare Pages / deploy (push) Waiting to run
fc056896e1
Merge branch 'dev' of ssh://ssh.forge.ucalgarybaja.ca:222/UCalgary_Baja/ucalg-baja-ca into dev
Some checks are pending
Deploy to Cloudflare Pages / deploy (push) Waiting to run
d5f761c1bd
remove(BannerImage): removed old css comments
Some checks are pending
Deploy to Cloudflare Pages / deploy (push) Waiting to run
e22cccabd3
Merge branch 'dev' of ssh://ssh.forge.ucalgarybaja.ca:222/UCalgary_Baja/ucalg-baja-ca into dev
Some checks failed
Deploy to Cloudflare Pages / deploy (push) Has been cancelled
eaeeb590d9
feat(Added banners)
Some checks failed
Deploy to Cloudflare Pages / deploy (push) Has been cancelled
dbfaaef7d5
Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>

Update .forgejo/workflows/deploy_to_cloudflare.yaml

Update .forgejo/workflows/deploy_to_cloudflare.yaml

Update .forgejo/workflows/deploy_to_cloudflare.yaml

Update .forgejo/workflows/deploy_to_cloudflare.yaml

Update .forgejo/workflows/deploy_to_cloudflare.yaml

fix(actions): fixed project name

Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>

fix(actions): fixed project name

Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>

feat(actions): more detailed webhook notification

Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>

feat(actions): more detailed webhook notification using curl

Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>

feat(Sponsors): Added static sponsors, updated sponsor logos.

fix(action): syntax

Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>

Fix(action): removing tailing /

Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>

fix(actions): using <> instead of []()

Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>
feat(webhook): shows deployment url and branch preview url
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 1m26s
ab722c6b1f
fix(actions): brought back working actions with proper links
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 1m18s
eba3b05295
init(Gallery) (1)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 54s
5e2dbe4c9e
feat(Gallery)! added more style tags and state runes (#1)
Some checks failed
Deploy to Cloudflare Pages / deploy (push) Failing after 18s
a60264624f
feat(Gallery) Made the proper design for my gallery, added auto scroll and opens a window (#1)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 42s
e89c5e402f
Feat(Gallery)^:improved the window feature, made it look nicer (#1)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 1m11s
8dbcb69649
feat(Gallery)^:finished the props function within the code, and further styled the close button (#1)
Some checks failed
Deploy to Cloudflare Pages / deploy (push) Failing after 47s
ae3510cb9a
Feat(Gallery) cleaned up the props list, added an alt and image link to make it more readable, adjusted the code as needed (#1)
Some checks failed
Deploy to Cloudflare Pages / deploy (push) Failing after 37s
Deploy to Cloudflare Pages / deploy (pull_request) Failing after 37s
c2267b0593
cnidariaware changed target branch from master to dev 2025-11-20 13:25:28 -07:00
cnidariaware left a comment

@Aarsh-T Just make these changes, remove unused and ensure it passes the upload test

@Aarsh-T Just make these changes, remove unused and ensure it passes the upload test
@ -0,0 +8,4 @@
'https://pictures.altai-travel.com/1920x1040/mount-everest-aerial-view-himalayas-istock-3745.jpg'
]
} = $props();
Owner

change to new list of dictionaries

change to new list of dictionaries
Aarsh-T marked this conversation as resolved
@ -0,0 +20,4 @@
function prevSet() {
current_index = (current_index - 1 + photos.length) % photos.length;
}
Owner

generalize these two functions
take in a number and replace + - 1 with + input

and use {()=> functionName(+/-1)}

generalize these two functions take in a number and replace + - 1 with + input and use {()=> functionName(+/-1)}
Aarsh-T marked this conversation as resolved
@ -0,0 +38,4 @@
}, 5000);
</script>
<div class="gallery-container">
Owner

classes are not needed use

div {
 /* something */
}

div > div {
 /* something */
}

dialog > div {
 /* remove other somethings if unwanted */
}
classes are not needed use ```css div { /* something */ } div > div { /* something */ } dialog > div { /* remove other somethings if unwanted */ } ```
Aarsh-T marked this conversation as resolved
@ -0,0 +44,4 @@
src={photos[(current_index - 1 + photos.length) % photos.length]}
alt=""
class="main-photo"
on:click={() => openDialog(photos[(current_index - 1 + photos.length) % photos.length])}
Owner

surround with a tag for accessibility and move the onlick to the

same with the other 3 img

surround with a <a> tag for accessibility and move the onlick to the <a> same with the other 3 img
Aarsh-T marked this conversation as resolved
@ -0,0 +58,4 @@
class="main-photo"
on:click={() => openDialog(photos[(current_index + 1) % photos.length])}
/>
</div>
Owner

also not needed
use

div > div:nth-child(2) {
 /* something */
}
also not needed use ```css div > div:nth-child(2) { /* something */ }
Aarsh-T marked this conversation as resolved
@ -0,0 +68,4 @@
{#if dialogOpen}
<dialog open class="image-dialog" onclick={closeDialog}>
<div class="dialog-content">
Owner

class is not needed here

class is not needed here
Owner

nor for above

nor for above
Aarsh-T marked this conversation as resolved
@ -0,0 +70,4 @@
{#if dialogOpen}
<dialog open class="image-dialog" on:click={closeDialog}>
<div class="dialog-content" on:click|stopPropagation>
Owner

class is not needed, use

dialog > button {}
class is not needed, use ```css dialog > button {} ```
Aarsh-T marked this conversation as resolved
@ -0,0 +118,4 @@
}
.button-container button.selected {
background-color: rgba(255, 255, 255, 0.7);
Owner

only selected is needed

only selected is needed
Author
Member

using just selected removes the highlight feature for the button for some reason, so i changed it to simply div div:nth-child(2) .selected

using just selected removes the highlight feature for the button for some reason, so i changed it to simply div div:nth-child(2) .selected
Aarsh-T marked this conversation as resolved
@ -0,0 +142,4 @@
position: fixed;
max-width: 90%;
max-height: 90%;
}
Owner

don't need dialog in front

don't need dialog in front
Aarsh-T marked this conversation as resolved
@ -132,4 +135,1 @@
max-width: 700px;
padding: 0 1svw;
}
Owner

this shouldn't have been removed

this shouldn't have been removed
Aarsh-T marked this conversation as resolved
@ -121,4 +128,0 @@
height: 400px;
width: 400px;
}
Owner

also put back if no warning for unused

also put back if no warning for unused
Aarsh-T marked this conversation as resolved
cnidariaware removed their assignment 2025-11-22 10:26:40 -07:00
Feat(Gallery)^: made the timer stop when the dialog is open, and reset whent he button is clicked (#1)
Some checks failed
Deploy to Cloudflare Pages / deploy (push) Failing after 36s
Deploy to Cloudflare Pages / deploy (pull_request) Failing after 33s
30b9de85a3
Feat(Gallery)^: made it work on mobile, and added a swiping mechanism (#1)
Some checks failed
Deploy to Cloudflare Pages / deploy (push) Failing after 40s
Deploy to Cloudflare Pages / deploy (pull_request) Failing after 33s
c789cf86f8
Owner

replace with .jpg instead of .JPG to fix check

replace with .jpg instead of .JPG to fix check
cnidariaware added the due date 2025-12-20 2025-11-26 10:20:46 -07:00
feat(Gallery) simply moved the gallery images out of the designated spot (#1)
Some checks failed
Deploy to Cloudflare Pages / deploy (push) Failing after 41s
Deploy to Cloudflare Pages / deploy (pull_request) Failing after 35s
ac657e1b09
feat(Gallery) moved the images back into assests (#1)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 59s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 1m6s
317dd9fe52
cnidariaware left a comment

Make these changes

Make these changes
@ -0,0 +32,4 @@
current_index = (current_index + step + photos.length) % photos.length;
}
function openDialog(image) {
Owner

comment your functions

here is how for Javacript

comment your functions here is how for [Javacript](https://forge.ucalgarybaja.ca/ucalgary-baja/Baja-Coding-Practices/src/branch/master/Function%20Standards.md#javascript)
Aarsh-T marked this conversation as resolved
@ -0,0 +42,4 @@
dialogOpen = false;
selected = 0;
startTimer();
}
Owner

merge open and close dialog into one use

dialogOpen = !dialogOpen

and a if statement with the clearTimeout or start timer

merge open and close dialog into one use ```javascript dialogOpen = !dialogOpen ``` and a if statement with the clearTimeout or start timer
Aarsh-T marked this conversation as resolved
@ -0,0 +197,4 @@
padding: 0;
}
div div:nth-child(2) .selected {
Owner

why is there a selector before a class

why is there a selector before a class
Aarsh-T marked this conversation as resolved
@ -0,0 +169,4 @@
}
div:first-of-type > div:first-child > img:nth-child(1),
div:first-of-type > div:first-child > img:nth-child(3) {
Owner

use the odd selector

use the odd selector
Aarsh-T marked this conversation as resolved
Feat(Gallery)^:updated the functions with proper comments (#1)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 1m2s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 1m6s
43c30df3b0
cnidariaware left a comment

just change from event to null

just change from event to null
@ -0,0 +94,4 @@
}
/**
* @param {event} - takes the event at which the finger mves across the screen
Owner

param null

param null
Aarsh-T marked this conversation as resolved
Feat(Gallery) fixed the function comments (#28)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 1m4s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 1m2s
3f634534c5
Feat(Gallery)^:fixed the function comments once again (#28)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 1m1s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 1m0s
b7cb1c2344
@ -0,0 +95,4 @@
}
/**
* @param {null} event - takes the event at which the finger mves across the screen
Owner

use event type instead

use event type instead
Feat(Gallery) fixed the comments again (#28)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 1m3s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 1m0s
583038a515
cnidariaware left a comment

Good, only one minor styling problem, this should be fixed on dev then getting another reivew

Good, only one minor styling problem, this should be fixed on dev then getting another reivew
@ -0,0 +269,4 @@
max-height: 90%;
}
dialog #window-image {
Owner

dont need the dialog before but it looks more readible

dont need the dialog before but it looks more readible
cnidariaware deleted branch Gallery 2025-11-26 20:36:03 -07:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

2025-12-20

Depends on
#1 Gallery Component - Programming
ucalgary-baja/ucalg-baja-ca
Reference
ucalgary-baja/ucalg-baja-ca!28
No description provided.