Merging the Recruitment Form (Frontend + Captcha) into Dev Branch #36
No reviewers
Labels
No labels
Confirmed
Confirmed
Confirmed
Duplicate
Confirmed
Invalid
Confirmed
Review Needed
Confirmed
Won't Fix
Digital Dash
JavaScript
React
JavaScript
Svelte
Kind
Bug
Kind
Enhancement
Kind
Feature
Kind
Security
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Role
All Members
Role
Future Software Lead
Role
Intermediate Member
Role
Junior Member
Role
Senior Member
Role
Software Lead
Size
L
Size
M
Size
S
Size
XL
Size
XS
Status
Abandoned
Status
Blocked
Status
Help wanted
Status
Need More Info
Status
Question
Tech
Actions
Tech
C
Tech
C++
Tech
CSS
Tech
Docker
Tech
Draw.io
Tech
Golang
Tech
HTML
Tech
JavaScript
Tech
Python
Tech
Rust
Tech
Terraform
UI
Component
UI
Layout
UI
Page
Work Type
Design Work
Work Type
Development
Work Type
Documentation
Work Type
Review
Work Type
Testing
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
ucalgary-baja/ucalg-baja-ca!36
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "rform"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -0,0 +1,535 @@<script lang="ts">I see more AI
completes #33
make the changes commented
@ -0,0 +1,535 @@<script lang="ts">import TopBanner from '$lib/components/TopBanner.svelte';change dir to recruitment
@ -0,0 +12,4 @@let email = $state('');let ucid = $state('');let isSubmitting = $state(false);let submitError = $state('');why are any of these needed, these should be read from a FormObject
@ -0,0 +28,4 @@let major = $state('');let majorOther = $state('');let isOtherMajor = $derived(major.startsWith('Other'));Also not needed
@ -0,0 +33,4 @@let year_of_study = $state('');const availabilityOptions = ['Yes', 'No', 'Partial'];let availability = $state('');Again more unneed states
@ -0,0 +53,4 @@let interest_question = $state('');const teamQuestionText: Record<string, string> = {create a lib module instead and just import it
@ -0,0 +48,4 @@'Business'];let first_preference_sub_team = $state('');remove
@ -0,0 +49,4 @@];let first_preference_sub_team = $state('');let second_preference_sub_team = $state('');remove
@ -0,0 +51,4 @@let first_preference_sub_team = $state('');let second_preference_sub_team = $state('');let interest_question = $state('');remove
@ -0,0 +71,4 @@// Store answers keyed by team name: answers['Software'] = '...'let technical_question_internal = $state<Partial<Record<QuestionTeam, string>>>({});unneeded state
@ -0,0 +106,4 @@}});function getRecaptchaToken(action: string): Promise<string> {JS docs please see here
@ -0,0 +126,4 @@});}async function handleSubmit(e: SubmitEvent) {JS docs please see here
@ -0,0 +133,4 @@submitError = '';if (!form.reportValidity()) return;why?
@ -0,0 +195,4 @@<div class="wrap"><h2>UCalgary Baja Recruitment Form</h2><p class="sub" style="font-style: italic">replace the style with an
<i>tagwhat?
@ -0,0 +157,4 @@recaptchaToken};const res = await fetch('/recruitmentform', {remove with an if statement, and replace later with the actual backend url
In its place just console.log() with the payload
@ -0,0 +159,4 @@const res = await fetch('/recruitmentform', {method: 'POST',headers: {remove this is not needed
@ -0,0 +191,4 @@<scriptsrc={`https://www.google.com/recaptcha/api.js?render=${PUBLIC_RECAPTCHA_SITE_KEY}`}></script></svelte:head>remove svelte:head that is AI
@ -0,0 +299,4 @@<div class="row"><label for="sub-team-descriptions">Sub-Team Descriptions:</label><p id="sub-team-descriptions" class="hint"><b>Chassis</b> – The chassis involves the car's frame, providing support for all the otherAI em dashes, remove
@ -0,0 +353,4 @@{@const team = t as QuestionTeam}<div class="row" style="margin-top: 12px;"><label for={`${team}-question-answer`}this is AI, remove the ` and $
@ -0,0 +454,4 @@font-weight: normal;white-space: nowrap;}@media (max-width: 1000px) {change to 800px
@ -0,0 +365,4 @@{/if}<inputid={`${team}-question-answer`}same here as above
@ -0,0 +1,87 @@import { json } from '@sveltejs/kit';remove file not needed as we are creating a backend
@ -0,0 +60,4 @@color: black;}@media (max-width: 600px) {should be same as the form, 800px
Make these changes

and rejected
@ -0,0 +8,4 @@execute: (siteKey: string, options: { action: string }) => Promise<string>;};let formEl = $state<HTMLFormElement | null>(null);can do with this instead
@ -0,0 +12,4 @@let isSubmitting = $state(false);let submitError = $state('');let showOtherMajor = $state(false);let selectedTeams = $state<string[]>([]);dont need
@ -0,0 +108,4 @@*/async function handleSubmit(e: SubmitEvent) {e.preventDefault();use form data conversion here on e
@ -0,0 +203,4 @@type="text"requiredinputmode="numeric"pattern="^\d+$"I dont thing you need pattern and numeric
@ -0,0 +7,4 @@result = result - xelse:result = result + x`,Chassis: `Example Chassis Question: What is one safety consideration in chassis design?`formatted incorrectly
insert this
@ -0,0 +9,4 @@result = result + x`,Chassis: `Example Chassis Question: What is one safety consideration in chassis design?`} as const;add options
a) 1 b) 0
c) -11 d) -10
just send answer to backend
View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.