sponsor #29

Merged
cnidariaware merged 17 commits from sponsor into dev 2025-12-20 14:34:23 -07:00
Member
No description provided.
Feat(sponsors): Iteration through each element of Sponsors data (#2)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 59s
d616a0d6ff
Feat(Sponsor): Initial display of the sponsor logo
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 47s
8f84df3b7f
Feat(Sponsor)^: Displaying images properly (#2)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 45s
4a0971e3ca
Feat(Sponsor)^: Styling the content-1 (#2)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 1m10s
a3607c353e
Feat(Sponsor)^:Styling the page-2 (#2)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 57s
ba25c19fe0
Feat(Sponsor)^:Added a tags and made it look prettier(#2)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 54s
b06b092a53
Feat(Sponsor): Sponsorship package and finsihed styling(#2)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 58s
a7e1385aa2
Feat(Sponsor): Mobile view(#18)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 50s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 58s
b1277f59d6
cnidariaware left a comment

Make these changes for desktop

Make these changes for desktop
@ -3,0 +3,4 @@
let sponsorInfo = $state('');
let order = ['Diamond Tier', 'Platinum Tier', 'Gold Tier', 'Silver Tier', 'Bronze Tier'];
let gotThing = $state(false);
const fetchingData = async () => {
Owner

remove got thing

space out function from variables and import

change let order to const order and place above rune

remove got thing space out function from variables and import change let order to const order and place above rune
Owner

fetchingData is a bad function name

make more clear what it is doing
for example "getSponsors"

fetchingData is a bad function name make more clear what it is doing for example "getSponsors"
Owner
Add JSDoc comments to function See [Baja Software Comment and Function Template (Javascript Link)](https://forge.ucalgarybaja.ca/ucalgary-baja/Baja-Coding-Practices/src/branch/master/Function%20Standards.md#javascript)
siddharth24 marked this conversation as resolved
@ -11,0 +24,4 @@
<div>
<h4>Current sponsors</h4>
<button onclick={fetchingData}> Press me </button>
{#if sponsorInfo !== ''}
Owner

change to $effect when backend deployed

change to $effect when backend deployed
Owner

Do now instead of waiting

Do now instead of waiting
siddharth24 marked this conversation as resolved
@ -25,0 +56,4 @@
<h4>Sponsorship Benefits</h4>
<div class="table-wrapper">
<table class="sponsor-table">
<thead>
Owner

remove classes and most likely the div surrounding the table

remove classes and most likely the div surrounding the table
siddharth24 marked this conversation as resolved
@ -256,0 +214,4 @@
vivamus fringilla lacus nec metus bibendum egestas. Iaculis massa nisl malesuada lacinia integer
nunc posuere. Ut hendrerit semper vel class aptent taciti sociosqu. Ad litora torquent per
conubia nostra inceptos himenaeos.
</p>
Owner

replace this with real text

replace this with real text
siddharth24 marked this conversation as resolved
@ -25,0 +63,4 @@
<th>Silver<br />$1,000</th>
<th>Gold<br />$2,500</th>
<th>Platinum<br />$5,000</th>
<th>Diamond<br />$10,000</th>
Owner

No br, select the first tr then use width ch instead or change the number into a block so it gets a new line

No br, select the first tr then use width ch instead or change the number into a <span> block so it gets a new line
siddharth24 marked this conversation as resolved
@ -25,0 +97,4 @@
src="https://www.svgrepo.com/show/491212/cross.svg"
alt="Included"
/></td
>
Owner

remove class replace with

table img {
 /* cross sytling */
remove class replace with ```css table img { /* cross sytling */
siddharth24 marked this conversation as resolved
@ -53,0 +137,4 @@
class="cross"
src="https://www.svgrepo.com/show/491212/cross.svg"
alt="Included"
/></td
Owner

Make alt more descriptive

Make alt more descriptive
siddharth24 marked this conversation as resolved
@ -463,3 +297,1 @@
color: white;
text-align: center;
}
div > div > div > div > a > div {
Owner

it might make more sense to make each sponsor "block" a component that you feed data into to clean up this selection

it might make more sense to make each sponsor "block" a component that you feed data into to clean up this selection
siddharth24 marked this conversation as resolved
@ -508,3 +353,2 @@
</style>
.sponsor-table .cross {
Owner

no additional class needed here and remove class

no additional class needed here and remove class
siddharth24 marked this conversation as resolved
cnidariaware added the due date 2025-12-20 2025-11-26 10:20:30 -07:00
Feat(Sponsors): Cleared up some issues with the pull request(#2)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 47s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 52s
74b4844af9
cnidariaware left a comment

Make these changes @siddharth24

Make these changes @siddharth24
@ -0,0 +4,4 @@
let message = '';
let isButtonDisabled = false;
let submitText = 'Submit';
async function formSubmit(e) {
Owner

missing js doc comments look here for said comments

missing js doc comments look [here](https://forge.ucalgarybaja.ca/ucalgary-baja/Baja-Coding-Practices/src/branch/master/Function%20Standards.md#javascript) for said comments
siddharth24 marked this conversation as resolved
@ -0,0 +31,4 @@
}
</script>
<form on:submit|preventDefault={(e) => formSubmit(e)}>
Owner

change to this

<form onsubmit={formSubmit}>
change to this ```html <form onsubmit={formSubmit}> ```
siddharth24 marked this conversation as resolved
@ -0,0 +43,4 @@
<span></span>
<button id="ContactUsSubmit" type="submit" disabled={isButtonDisabled}>
Owner

remove id

remove id
siddharth24 marked this conversation as resolved
@ -2,1 +2,4 @@
import TopBanner from '$lib/components/TopBanner.svelte';
import Contact from '$lib/components/contact.svelte';
let sponsorInfo = $state('');
let order = ['Diamond Tier', 'Platinum Tier', 'Gold Tier', 'Silver Tier', 'Bronze Tier'];
Owner

change from let to const

const sponsorInfo
change from let to const ```javascript const sponsorInfo ```
siddharth24 marked this conversation as resolved
@ -3,0 +8,4 @@
let test = await sponsors.json();
sponsorInfo = await test;
gotThing = true;
Owner

remove this variable

remove this variable
siddharth24 marked this conversation as resolved
Owner

please text me if i don't notice when you made changes and press the request review button

please text me if i don't notice when you made changes and press the request review button
Feat(Sponsors): Completed most of the comments and working on the contact us(#2)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 50s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 48s
2715c885db
cnidariaware left a comment

@siddharth24 Make the commented changes

@siddharth24 Make the commented changes
@ -3,0 +3,4 @@
import Contact from '$lib/components/contact.svelte';
let sponsorInfo = $state('');
let order = ['Diamond Tier', 'Platinum Tier', 'Gold Tier', 'Silver Tier', 'Bronze Tier'];
const getSponsors = async () => {
Owner

JSDoc comments missing

See here

JSDoc comments missing See [here](https://forge.ucalgarybaja.ca/ucalgary-baja/Baja-Coding-Practices/src/branch/master/Function%20Standards.md#javascript)
siddharth24 marked this conversation as resolved
Feat(Sponsor): and the contact form(#2)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 43s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 42s
fe0c261c35
@ -256,0 +151,4 @@
fundraising, sourcing materials, team management, and project coordination. We deeply value the
partnership with our sponsors, as their support makes every project and competition possible. If
you're interested in sponsoring UCalgary Baja, please contact our team captain at
uofcbaja@gmail.com. Below, you can find our sponsorship package detailing the opportunities
Owner

update email to

<a href="mailto:club@ucalgarybaja.ca">club@ucalgarybaja.ca</a>
update email to ```html <a href="mailto:club@ucalgarybaja.ca">club@ucalgarybaja.ca</a>
siddharth24 marked this conversation as resolved
@ -0,0 +34,4 @@
});
isButtonDisabled = false;
submitText = 'Submit';
}
Owner

move the isButtonDisabled and submitText into the function in then

move the isButtonDisabled and submitText into the function in then
cnidariaware marked this conversation as resolved
Owner

back-end now deployed

use https://api.ucalgarybaja.ca/sponsors instead of localhost

back-end now deployed use https://api.ucalgarybaja.ca/sponsors instead of localhost
cnidariaware left a comment

Make these changes, we may want to use css nesting for increased clarity but that is for later

Make these changes, we may want to use css nesting for increased clarity but that is for later
@ -0,0 +6,4 @@
let message = $state('');
let isButtonDisabled = $state(false);
let submitText = $state('Submit');
async function formSubmit(e) {
Owner

add issue to change from a $state to a formobject processing

add issue to change from a $state to a formobject processing
Owner

JSDoc comments see here

JSDoc comments see [here](https://forge.ucalgarybaja.ca/ucalgary-baja/Baja-Coding-Practices/src/branch/master/Function%20Standards.md#javascript)
siddharth24 marked this conversation as resolved
@ -0,0 +48,4 @@
<label for="Message">Message</label>
<textarea name="Message" bind:value={message} required></textarea>
Owner

add hidden input box for bots/spam to filter them out, no normal human should be able to see or fill out

add hidden input box for bots/spam to filter them out, no normal human should be able to see or fill out
siddharth24 marked this conversation as resolved
@ -0,0 +49,4 @@
<label for="Message">Message</label>
<textarea name="Message" bind:value={message} required></textarea>
<span></span>
Owner

This is for error handling not for spacing primarily

This is for error handling not for spacing primarily
siddharth24 marked this conversation as resolved
@ -0,0 +62,4 @@
:root {
--card-background-color: rgba(38, 38, 38, 0.5);
--card-border-radius: 0.5rem;
}
Owner

remove and move to globals.css if not already present

remove and move to globals.css if not already present
siddharth24 marked this conversation as resolved
@ -0,0 +64,4 @@
--card-border-radius: 0.5rem;
}
div {
Owner

remove div and replace with just form, also remove the div tag

remove div and replace with just form, also remove the div tag
siddharth24 marked this conversation as resolved
@ -0,0 +126,4 @@
}
/* Spacer element */
span {
Owner

should be same as input boxes, only give a background colour if there is text/error

should be same as input boxes, only give a background colour if there is text/error
siddharth24 marked this conversation as resolved
@ -240,4 +135,0 @@
If you're interested in sponsoring UCalgary Baja, please contact our team
captain at
<a href="mailto:uofcbaja@gmail.com"><span>uofcbaja@gmail.com</span></a>.
</p>
Owner

bring back a tag and change to club@ucalgarybaja.ca

bring back a tag and change to [club@ucalgarybaja.ca](mailto:club@ucalgarybaja.ca)
siddharth24 marked this conversation as resolved
@ -3,0 +21,4 @@
$effect(async () => {
// sponsorPromise = fetch('http://localhost:6526/sponsors').then((res) => res.json());
sponsorPromise = (async () => {
Owner

already been stated but replace localhost with https://api.ucalgarybaja.ca/sponsors

already been stated but replace localhost with [https://api.ucalgarybaja.ca/sponsors](https://api.ucalgarybaja.ca/sponsors)
siddharth24 marked this conversation as resolved
Feat(sponsors): Pull request changes as requested(#2)
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 49s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 50s
63e78b1e2f
feat(sponsors): added missing variables
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 42s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 41s
6da08488f9
Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>
feat(sponsor): removed overflowing input boxes
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 50s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 45s
794ad4f487
Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>
feat(sponsor): centered p tag and fixed -10 error
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 41s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 51s
846274e372
Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>
feat(sponsor): now mailto link in thank you message
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 48s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 47s
7ab00091af
Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>
feat(sponsor): now hover effect and bolding present
All checks were successful
Deploy to Cloudflare Pages / deploy (push) Successful in 43s
Deploy to Cloudflare Pages / deploy (pull_request) Successful in 50s
bb2a830430
Signed-off-by: darkicewolf50 <brock@darkicewolf50.dev>
cnidariaware left a comment

@siddharth24 I am happy with the current state of this

Make these changes on dev when this has merged

Have a great rest of our year see you on the 27, or the 3rd

@siddharth24 I am happy with the current state of this Make these changes on dev when this has merged Have a great rest of our year see you on the 27, or the 3rd
@ -256,0 +146,4 @@
fundraising, sourcing materials, team management, and project coordination. We deeply value the
partnership with our sponsors, as their support makes every project and competition possible. If
you're interested in sponsoring UCalgary Baja, please contact our team captain at
<a href="mailto:club@ucalgarybaja.ca">club@ucalgarybaja.ca</a>. Below, you can find our sponsorship package detailing the opportunities
Owner

only this needs styling

Link the uofcbaja@gmail.com link here

only this needs styling Link the uofcbaja@gmail.com link [here](https://ucalgarybaja.ca/OurSponsors)
@ -470,2 +283,2 @@
/* margin: 0px; */
}
.sponsor-table th,
.sponsor-table td {
Owner

remove classes

remove classes
cnidariaware deleted branch sponsor 2025-12-20 14:34:23 -07:00
Sign in to join this conversation.
No reviewers
No milestone
No project
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

2025-12-20

Depends on
#2 Sponsors Page - Programming
ucalgary-baja/ucalg-baja-ca
#18 Sponsors Page - Mobile Programming
ucalgary-baja/ucalg-baja-ca
Reference
ucalgary-baja/ucalg-baja-ca!29
No description provided.