sponsor #29
No reviewers
Labels
No labels
Confirmed
Confirmed
Confirmed
Duplicate
Confirmed
Invalid
Confirmed
Review Needed
Confirmed
Won't Fix
Digital Dash
JavaScript
React
JavaScript
Svelte
Kind
Bug
Kind
Enhancement
Kind
Feature
Kind
Security
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Role
All Members
Role
Future Software Lead
Role
Intermediate Member
Role
Junior Member
Role
Senior Member
Role
Software Lead
Size
L
Size
M
Size
S
Size
XL
Size
XS
Status
Abandoned
Status
Blocked
Status
Help wanted
Status
Need More Info
Status
Question
Tech
Actions
Tech
C
Tech
C++
Tech
CSS
Tech
Docker
Tech
Draw.io
Tech
Golang
Tech
HTML
Tech
JavaScript
Tech
Python
Tech
Rust
Tech
Terraform
UI
Component
UI
Layout
UI
Page
Work Type
Design Work
Work Type
Development
Work Type
Documentation
Work Type
Review
Work Type
Testing
No milestone
No project
No assignees
2 participants
Notifications
Due date
Depends on
#2 Sponsors Page - Programming
ucalgary-baja/ucalg-baja-ca
#18 Sponsors Page - Mobile Programming
ucalgary-baja/ucalg-baja-ca
Reference
ucalgary-baja/ucalg-baja-ca!29
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "sponsor"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Make these changes for desktop
@ -3,0 +3,4 @@let sponsorInfo = $state('');let order = ['Diamond Tier', 'Platinum Tier', 'Gold Tier', 'Silver Tier', 'Bronze Tier'];let gotThing = $state(false);const fetchingData = async () => {remove got thing
space out function from variables and import
change let order to const order and place above rune
fetchingData is a bad function name
make more clear what it is doing
for example "getSponsors"
Add JSDoc comments to function
See Baja Software Comment and Function Template (Javascript Link)
@ -11,0 +24,4 @@<div><h4>Current sponsors</h4><button onclick={fetchingData}> Press me </button>{#if sponsorInfo !== ''}change to $effect when backend deployed
Do now instead of waiting
@ -25,0 +56,4 @@<h4>Sponsorship Benefits</h4><div class="table-wrapper"><table class="sponsor-table"><thead>remove classes and most likely the div surrounding the table
@ -256,0 +214,4 @@vivamus fringilla lacus nec metus bibendum egestas. Iaculis massa nisl malesuada lacinia integernunc posuere. Ut hendrerit semper vel class aptent taciti sociosqu. Ad litora torquent perconubia nostra inceptos himenaeos.</p>replace this with real text
@ -25,0 +63,4 @@<th>Silver<br />$1,000</th><th>Gold<br />$2,500</th><th>Platinum<br />$5,000</th><th>Diamond<br />$10,000</th>No br, select the first tr then use width ch instead or change the number into a block so it gets a new line
@ -25,0 +97,4 @@src="https://www.svgrepo.com/show/491212/cross.svg"alt="Included"/></td>remove class replace with
@ -53,0 +137,4 @@class="cross"src="https://www.svgrepo.com/show/491212/cross.svg"alt="Included"/></tdMake alt more descriptive
@ -463,3 +297,1 @@color: white;text-align: center;}div > div > div > div > a > div {it might make more sense to make each sponsor "block" a component that you feed data into to clean up this selection
@ -508,3 +353,2 @@</style>.sponsor-table .cross {no additional class needed here and remove class
Make these changes @siddharth24
@ -0,0 +4,4 @@let message = '';let isButtonDisabled = false;let submitText = 'Submit';async function formSubmit(e) {missing js doc comments look here for said comments
@ -0,0 +31,4 @@}</script><form on:submit|preventDefault={(e) => formSubmit(e)}>change to this
@ -0,0 +43,4 @@<span></span><button id="ContactUsSubmit" type="submit" disabled={isButtonDisabled}>remove id
@ -2,1 +2,4 @@import TopBanner from '$lib/components/TopBanner.svelte';import Contact from '$lib/components/contact.svelte';let sponsorInfo = $state('');let order = ['Diamond Tier', 'Platinum Tier', 'Gold Tier', 'Silver Tier', 'Bronze Tier'];change from let to const
@ -3,0 +8,4 @@let test = await sponsors.json();sponsorInfo = await test;gotThing = true;remove this variable
please text me if i don't notice when you made changes and press the request review button
@siddharth24 Make the commented changes
@ -3,0 +3,4 @@import Contact from '$lib/components/contact.svelte';let sponsorInfo = $state('');let order = ['Diamond Tier', 'Platinum Tier', 'Gold Tier', 'Silver Tier', 'Bronze Tier'];const getSponsors = async () => {JSDoc comments missing
See here
@ -256,0 +151,4 @@fundraising, sourcing materials, team management, and project coordination. We deeply value thepartnership with our sponsors, as their support makes every project and competition possible. Ifyou're interested in sponsoring UCalgary Baja, please contact our team captain atuofcbaja@gmail.com. Below, you can find our sponsorship package detailing the opportunitiesupdate email to
@ -0,0 +34,4 @@});isButtonDisabled = false;submitText = 'Submit';}move the isButtonDisabled and submitText into the function in then
back-end now deployed
use https://api.ucalgarybaja.ca/sponsors instead of localhost
Make these changes, we may want to use css nesting for increased clarity but that is for later
@ -0,0 +6,4 @@let message = $state('');let isButtonDisabled = $state(false);let submitText = $state('Submit');async function formSubmit(e) {add issue to change from a $state to a formobject processing
JSDoc comments see here
@ -0,0 +48,4 @@<label for="Message">Message</label><textarea name="Message" bind:value={message} required></textarea>add hidden input box for bots/spam to filter them out, no normal human should be able to see or fill out
@ -0,0 +49,4 @@<label for="Message">Message</label><textarea name="Message" bind:value={message} required></textarea><span></span>This is for error handling not for spacing primarily
@ -0,0 +62,4 @@:root {--card-background-color: rgba(38, 38, 38, 0.5);--card-border-radius: 0.5rem;}remove and move to globals.css if not already present
@ -0,0 +64,4 @@--card-border-radius: 0.5rem;}div {remove div and replace with just form, also remove the div tag
@ -0,0 +126,4 @@}/* Spacer element */span {should be same as input boxes, only give a background colour if there is text/error
@ -240,4 +135,0 @@If you're interested in sponsoring UCalgary Baja, please contact our teamcaptain at<a href="mailto:uofcbaja@gmail.com"><span>uofcbaja@gmail.com</span></a>.</p>bring back a tag and change to club@ucalgarybaja.ca
@ -3,0 +21,4 @@$effect(async () => {// sponsorPromise = fetch('http://localhost:6526/sponsors').then((res) => res.json());sponsorPromise = (async () => {already been stated but replace localhost with https://api.ucalgarybaja.ca/sponsors
@siddharth24 I am happy with the current state of this
Make these changes on dev when this has merged
Have a great rest of our year see you on the 27, or the 3rd
@ -256,0 +146,4 @@fundraising, sourcing materials, team management, and project coordination. We deeply value thepartnership with our sponsors, as their support makes every project and competition possible. Ifyou're interested in sponsoring UCalgary Baja, please contact our team captain at<a href="mailto:club@ucalgarybaja.ca">club@ucalgarybaja.ca</a>. Below, you can find our sponsorship package detailing the opportunitiesonly this needs styling
Link the uofcbaja@gmail.com link here
@ -470,2 +283,2 @@/* margin: 0px; */}.sponsor-table th,.sponsor-table td {remove classes